[zwavejs] Fix NullPointerException with ZUI 11.5.2#19500
[zwavejs] Fix NullPointerException with ZUI 11.5.2#19500lolodomo merged 2 commits intoopenhab:mainfrom
NullPointerException with ZUI 11.5.2#19500Conversation
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a NullPointerException that occurs in the Z-Wave JS binding when using ZUI version 11.5.2. The fix adds support for a new TIMEOUT metadata type that was introduced in the newer ZUI version but not handled by the binding.
- Added support for the new
TIMEOUTmetadata type in the enum definition - Updated metadata processing to handle
TIMEOUTtypes by treating them as time-based number items - Removed the automatic conversion of
DURATIONtoNUMBERtype and added explicit handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MetadataType.java | Added new TIMEOUT enum value with proper JSON serialization |
| ConfigMetadata.java | Added TIMEOUT case to switch statement for type conversion |
| BaseMetadata.java | Removed DURATION to NUMBER conversion and added explicit handling for both DURATION and TIMEOUT as time-based items |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
To the reviewer, there is no point in reviewing this json, as it is generated by ZUI
|
Is this already available in a snapshot? |
Unfortunately it was not yet merged, so it is not yet in the snapshots (or the just released milestone) |
Cherry-picking the change in 5.0.x is failing. |
|
what does it mean, in which version is the fix included? |
5.1.0 Snapshots (already available), 5.1.0 milestone 3 (due in about 2 weeks) and 5.1.0 stable (end of december) |
jlaur
added
the
backported
5 participants
Fixes: #19497
Should be backported to 5.0.x